Refactored Travis integration and added new targets #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of enabled targets:
On Linux:
+ gcc {4.7, 4.8, 4.9, 5.0, 6.0, 7.0} (without compat tests)
+ gcc 5.0 with compat tests enabled
+ clang {3.5, 3.6, 3.7, 3.8, 3.9, 4.0} (with libsdtc++)
On OSX:
+ XCode {7.3, 8, 8.2, 8.3, 9.0}
Missin Ones:
+ XCode 8.1 (Doesn't have CMake)
+ Linux Clang with libc++ (missing cxxabi.h)
+ Linux Clang 5.0 (missing <type_traits>)
|
Currently this build will show as failing because of g++-7 as discussed in issue #416, I have a working fix for it in PR #427 but I am not sure if it breaks things related to Clang, I will push it again after checking it on Travis. I've disabled some other targets that was failing and explained the reasons in more detail in #329. If this passes the review and I can fix the missing targets I am planning on adding Coverage scan (#348) or Valgrind support in Travis. |
|
I urge you to go with Coverity as it has proven to much more robust and sophisticated than Valgrind. I look forward to seeing it's integration with Cereal!! Keep up the amazing work 💯 👍 |
|
Merging, 7.0 bug should be fixed via #432 but I'll make sure it completes the checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of enabled targets:
On Linux:
On OSX:
Missin Ones: